New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor alert transports to classes #7844

Merged
merged 4 commits into from Dec 10, 2017

Conversation

Projects
None yet
5 participants
@mcq8
Contributor

mcq8 commented Dec 3, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Only moved the code to classes to have less ev[a|i]l code.
Next step could be to have the $obj as an actual object so integrators know what to expect from the var.
I'm not sure about the function name call. If you have any suggestions let me know.

@mcq8

This comment has been minimized.

Show comment
Hide comment
@mcq8

mcq8 Dec 3, 2017

Contributor

Seems like the Slack alerting is already making the project incompatible with php < 5.4.
I'll move it to the old array style and fix the linting.

Contributor

mcq8 commented Dec 3, 2017

Seems like the Slack alerting is already making the project incompatible with php < 5.4.
I'll move it to the old array style and fix the linting.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 3, 2017

Member

Running on my install for testing.

Member

laf commented Dec 3, 2017

Running on my install for testing.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 3, 2017

Member

Testing on mail transport works. Will code review soon.

Member

laf commented Dec 3, 2017

Testing on mail transport works. Will code review soon.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf
Member

laf commented Dec 6, 2017

@laf

laf approved these changes Dec 7, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Dec 8, 2017

Member

Great work @mcq8 Just a few cosmetic suggestions.

Member

murrant commented Dec 8, 2017

Great work @mcq8 Just a few cosmetic suggestions.

@laf laf added this to the 1.35 milestone Dec 9, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Dec 9, 2017

The inspection completed: 63 new issues, 52 updated code elements

scrutinizer-notifier commented Dec 9, 2017

The inspection completed: 63 new issues, 52 updated code elements

@InsaneSplash

This comment has been minimized.

Show comment
Hide comment
@InsaneSplash

InsaneSplash Dec 10, 2017

Contributor

I didn't test the old php version, but moving to php 7.1 resolved the problem.

Contributor

InsaneSplash commented Dec 10, 2017

I didn't test the old php version, but moving to php 7.1 resolved the problem.

@laf laf merged commit 5ff03d5 into librenms:master Dec 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.