New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Added support for wireless sensors #7846

Merged
merged 2 commits into from Dec 6, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Dec 3, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7742

@laf laf added API Feature labels Dec 3, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Dec 4, 2017

Member

Nice @laf. I shouldn't have named the primary key sensor_id, it should have been wireless_sensor_id... oh well.

Member

murrant commented Dec 4, 2017

Nice @laf. I shouldn't have named the primary key sensor_id, it should have been wireless_sensor_id... oh well.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 4, 2017

Member

Nice @laf. I shouldn't have named the primary key sensor_id, it should have been wireless_sensor_id... oh well.

No big deal

Member

laf commented Dec 4, 2017

Nice @laf. I shouldn't have named the primary key sensor_id, it should have been wireless_sensor_id... oh well.

No big deal

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Dec 6, 2017

Member

@laf tested. Add docs and this is ready to merge.

Member

murrant commented Dec 6, 2017

@laf tested. Add docs and this is ready to merge.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 6, 2017

Member

Thought I had :( Will do.

Member

laf commented Dec 6, 2017

Thought I had :( Will do.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 6, 2017

Member

Docs done

Member

laf commented Dec 6, 2017

Docs done

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Dec 6, 2017

The inspection completed: 6 new issues, 1 updated code elements

scrutinizer-notifier commented Dec 6, 2017

The inspection completed: 6 new issues, 1 updated code elements

@laf laf merged commit daa0773 into librenms:master Dec 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:api/issue-7742 branch Dec 6, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.