New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Some graphs broke due to stacked graphs, remove that change #7848

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Dec 3, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

@crcro can you check this please. I've removed the transparency on this as this doesn't work in rrdtool 1.4. I can't see a difference before and after this patch in 1.6 so not sure what the intention was with it.
If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Dec 3, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Dec 3, 2017

The inspection completed: No new issues

@crcro

This comment has been minimized.

Show comment
Hide comment
@crcro

crcro Dec 4, 2017

Contributor

@laf ... it should be visible only if using stacked graphs (have no issues with it, but also runnning rrdtool 1.7)

stacked (with transparency)
screen shot 2017-12-04 at 7 51 55 am

inverted (no transparency)
screen shot 2017-12-04 at 7 52 23 am

Contributor

crcro commented Dec 4, 2017

@laf ... it should be visible only if using stacked graphs (have no issues with it, but also runnning rrdtool 1.7)

stacked (with transparency)
screen shot 2017-12-04 at 7 51 55 am

inverted (no transparency)
screen shot 2017-12-04 at 7 52 23 am

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 4, 2017

Member

It is only used when stacked graphs are enabled but it's not compatible with rrdtool 1.4.x which we need to support.

Member

laf commented Dec 4, 2017

It is only used when stacked graphs are enabled but it's not compatible with rrdtool 1.4.x which we need to support.

@crcro

This comment has been minimized.

Show comment
Hide comment
@crcro

crcro Dec 4, 2017

Contributor

@laf ... able to reproduce bug, this seems to fix it.

Contributor

crcro commented Dec 4, 2017

@laf ... able to reproduce bug, this seems to fix it.

@laf laf merged commit 782dee6 into librenms:master Dec 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/graphs-dnos-cpu branch Dec 4, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 4, 2017

Member

Thanks @crcro

Member

laf commented Dec 4, 2017

Thanks @crcro

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.