New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: Added temp and humidity sesors + serial for websensor (renamed from cometsystem-p85xx) #7854

Merged
merged 1 commit into from Dec 11, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Dec 4, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7764

I'll need to do a notification for this but please review before this happens.

@laf laf referenced this pull request Dec 4, 2017

Closed

New Comet sensors #7764

5 of 5 tasks complete
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Dec 4, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Dec 4, 2017

The inspection completed: No new issues

@paulierco

This comment has been minimized.

Show comment
Hide comment
@paulierco

paulierco Dec 6, 2017

Thank you very much. It's working as expected.

Paul

paulierco commented Dec 6, 2017

Thank you very much. It's working as expected.

Paul

@laf laf changed the title from device: Added temp and humidity sesors + serial for websensor (rename d from cometsystem-p85xx) to device: Added temp and humidity sesors + serial for websensor (renamed from cometsystem-p85xx) Dec 6, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 6, 2017

Member

Merge the 11th of Dec.

Member

laf commented Dec 6, 2017

Merge the 11th of Dec.

@murrant

murrant approved these changes Dec 8, 2017

@laf laf removed the Blocker 🚫 label Dec 11, 2017

@laf laf merged commit 9601324 into librenms:master Dec 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:device/issue-7764 branch Dec 11, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.