New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove faulty memcached code (not related to distributed polling) #7881

Merged
merged 1 commit into from Dec 10, 2017

Conversation

Projects
None yet
2 participants
@murrant
Member

murrant commented Dec 9, 2017

Seen this cause:
slow page loads
incorrect (out of date) data
massive amounts of memory usage

I can't think of a single reason to enable it. Varnish is probably much more useful.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 9, 2017

Member

Absolutely no issues with this from me, how about adding it to validate to tell people it's deprecated if we detect the config is set and maybe a notification to also let people know?

Member

laf commented Dec 9, 2017

Absolutely no issues with this from me, how about adding it to validate to tell people it's deprecated if we detect the config is set and maybe a notification to also let people know?

@laf laf added the Refactor label Dec 9, 2017

@laf laf added this to the 1.35 milestone Dec 9, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Dec 10, 2017

Member

The main problem I have is I don't want to confuse people that use distributed polling. If we do a notification it will need to be worded carefully.

Member

murrant commented Dec 10, 2017

The main problem I have is I don't want to confuse people that use distributed polling. If we do a notification it will need to be worded carefully.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 10, 2017

Member

The main problem I have is I don't want to confuse people that use distributed polling. If we do a notification it will need to be worded carefully.

That's actually a pretty good reason.

Member

laf commented Dec 10, 2017

The main problem I have is I don't want to confuse people that use distributed polling. If we do a notification it will need to be worded carefully.

That's actually a pretty good reason.

@laf laf merged commit c22c879 into librenms:master Dec 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:remove-memcache branch Dec 11, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.