New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: Added detection for Cisco FTD devices #7887

Merged
merged 2 commits into from Dec 15, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Dec 9, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7783

@laf laf added the Device 🖥 label Dec 9, 2017

@laf laf referenced this pull request Dec 9, 2017

Closed

newdevice: Add support for Cisco FTD Devices #7783

5 of 5 tasks complete
Show outdated Hide outdated includes/definitions/ftd.yaml Outdated
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 10, 2017

Member

Good shout @murrant. Updated to include icmp response graph.

Member

laf commented Dec 10, 2017

Good shout @murrant. Updated to include icmp response graph.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Dec 10, 2017

The inspection completed: 86 new issues, 57 updated code elements

scrutinizer-notifier commented Dec 10, 2017

The inspection completed: 86 new issues, 57 updated code elements

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 15, 2017

Member

Confirmed working in the issue so merging in.

Member

laf commented Dec 15, 2017

Confirmed working in the issue so merging in.

@laf laf merged commit 02f0280 into librenms:master Dec 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:device/issue-7783 branch Dec 15, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.