New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent tries to insert processes data that is too long #7891

Merged
merged 1 commit into from Dec 13, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Dec 11, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@murrant murrant added the Bug 🐞 label Dec 11, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 11, 2017

Member

Do we want to strip that field down or just make the column bigger / text type?

Member

laf commented Dec 11, 2017

Do we want to strip that field down or just make the column bigger / text type?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Dec 11, 2017

Member

Not sure, I defaulted to truncating the field since that is better than the sql failing (which inserts all processes at once).

I'm guessing not many run into this issue.

Member

murrant commented Dec 11, 2017

Not sure, I defaulted to truncating the field since that is better than the sql failing (which inserts all processes at once).

I'm guessing not many run into this issue.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 11, 2017

Member

Some people don't know what they were missing until it appears.

Personally I'd move it to a text column as we shouldn't be manipulating data like that imho.

Member

laf commented Dec 11, 2017

Some people don't know what they were missing until it appears.

Personally I'd move it to a text column as we shouldn't be manipulating data like that imho.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Dec 13, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Dec 13, 2017

The inspection completed: No new issues

@laf laf merged commit e1b74a0 into librenms:master Dec 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fix-agent-processes branch Dec 15, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.