New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sending emails to "NOC" for default_email target #7917

Merged
merged 1 commit into from Dec 18, 2017

Conversation

Projects
None yet
3 participants
@deepseth
Contributor

deepseth commented Dec 15, 2017

It's confusing when emails are going to an address other than noc@, but showing as being sent to NOC, in mail clients. Better to just display the email address rather than making a name up.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 15, 2017

Member

It's probably easier just to set the name part to ''. You just get the email address used then.

Member

laf commented Dec 15, 2017

It's probably easier just to set the name part to ''. You just get the email address used then.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 18, 2017

Member

@deepseth You'll need to rebase as well to fix a travis issue.

Member

laf commented Dec 18, 2017

@deepseth You'll need to rebase as well to fix a travis issue.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Dec 18, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Dec 18, 2017

The inspection completed: No new issues

@laf laf merged commit 70d68db into librenms:master Dec 18, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.