New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor remove all old style snmp calls #7924

Merged
merged 1 commit into from Dec 20, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Dec 20, 2017

When calling snmpget (etc) this way it doesn't work with the save-tests-data.php script.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Dec 20, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Member

laf commented Dec 20, 2017

Tested a full discovery and polling has been running ok since I've checked this out. most of my dev won't use this code though so limited test. Code looks sane though.

@laf laf merged commit 046ed94 into librenms:master Dec 20, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:remove-direct-snmp branch Dec 21, 2017

@eimann

This comment has been minimized.

Contributor

eimann commented Dec 21, 2017

IMHO this triggers a lot of BGP down false-prositives on Ubiquity EdgeOS and Cisco IOS.
After daily.sh ran in den middle of the night a dozen alarms popped up.

@murrant

This comment has been minimized.

Member

murrant commented Dec 21, 2017

well, not so much false positives as totally breaks bgp-peers polling. #7934 fixes.

We should add some test data so the new tests can catch this...

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.