New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ZFS support for FreeBSD #7938

Merged
merged 7 commits into from Dec 30, 2017

Conversation

Projects
None yet
3 participants
@VVelox
Contributor

VVelox commented Dec 21, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Sadly only FreeBSD support right now. But this is a step in the right direction. As it uses JSON, getting Linux working should not be that big of an issue if I have some time eventually or if some one else wants to.

This depends on...

librenms/librenms-agent#156

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Dec 21, 2017

The inspection completed: 1 new issues, 2 updated code elements

@laf

This comment has been minimized.

Member

laf commented Dec 26, 2017

Can you post some screenshots of what this looks like please?

@laf laf added the Feature label Dec 26, 2017

@VVelox

This comment has been minimized.

Contributor

VVelox commented Dec 26, 2017

From app=zfs https://i.imgur.com/CxwrsSC.png

https://imgur.com/a/Zu19V

^--- some of the various graphs

EDIT: since imgur has a black BG and those are transparent PNGs, you will want to click on the image and select view image.

@laf

This comment has been minimized.

Member

laf commented Dec 26, 2017

License query posted in librenms/librenms-agent#156 for the actual application script. Once that's clarified / sorted then we can get this merged.

@VVelox

This comment has been minimized.

Contributor

VVelox commented Dec 27, 2017

https://www.gnu.org/licenses/license-list.en.html#FreeBSD

2-clause BSD is that with the last bit specific to FreeBSD removed.

@laf laf merged commit eaf70e9 into librenms:master Dec 30, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@VVelox VVelox deleted the VVelox:zfs branch Feb 20, 2018

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.