add ZFS support for FreeBSD #7938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to move it over to using JSON.
…king around debugging it all
|
The inspection completed: 1 new issues, 2 updated code elements |
|
Can you post some screenshots of what this looks like please? |
|
From app=zfs https://i.imgur.com/CxwrsSC.png ^--- some of the various graphs EDIT: since imgur has a black BG and those are transparent PNGs, you will want to click on the image and select view image. |
|
License query posted in librenms/librenms-agent#156 for the actual application script. Once that's clarified / sorted then we can get this merged. |
|
https://www.gnu.org/licenses/license-list.en.html#FreeBSD 2-clause BSD is that with the last bit specific to FreeBSD removed. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926Sadly only FreeBSD support right now. But this is a step in the right direction. As it uses JSON, getting Linux working should not be that big of an issue if I have some time eventually or if some one else wants to.
This depends on...
librenms/librenms-agent#156