New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved routeros sensors to yaml + fixed divisors #7946

Merged
merged 6 commits into from Jan 17, 2018

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Dec 23, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

This comment has been minimized.

Member

laf commented Dec 26, 2017

@murrant I'm not sure what the issue is here unless genuinely the move to yaml is breaking something.

Trying to run ./scripts/save-test-data.php -h 399 -o routeros -m sensors produces:

https://p.libren.ms/view/raw/592c13b7 which seems to contain some bad data. Any ideas without me trawling through the new code?

signal:
data:
-
oid: mtxrWlRtabStrength

This comment has been minimized.

@murrant

murrant Dec 27, 2017

Member

This doesn't seem right. It seems to be wireless client signal strength... It is indexed by MAC, which caused several issues.

It is also similar to the MSA issue with the string based index.

I would suggest dropping this sensor.

This comment has been minimized.

@laf

laf Jan 6, 2018

Member

Updated back to php

@murrant

This comment has been minimized.

Member

murrant commented Jan 9, 2018

@laf this looks good to me. Would you be willing to test the ./save-test-data.php script here?

Capture the data in master, then add here and hopefully everything passes.

@laf

This comment has been minimized.

Member

laf commented Jan 10, 2018

This is all the test data I have :(

@laf laf added the Refactor label Jan 10, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 17, 2018

The inspection completed: No new issues

@laf laf merged commit 1f03110 into librenms:master Jan 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:device/routeros-fanspeed branch Jan 17, 2018

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.