New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Added 404 fallback for bad / invalid calls #7952

Merged
merged 1 commit into from Jan 6, 2018

Conversation

Projects
None yet
2 participants
@laf
Copy link
Member

laf commented Dec 24, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Before any invalid api calls resulted in the LibreNMS index page being delivered. This now responds with:

{
    "status": "error",
    "message": "This API route doesn't exist."
}

@laf laf added the API label Dec 24, 2017

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Dec 24, 2017

The inspection completed: No new issues

@laf laf merged commit e2f122a into librenms:master Jan 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Copy link

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.