New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in bgp-peers poller #7976

Merged
merged 2 commits into from Dec 29, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Dec 29, 2017

peer data in wrong format
array_diff doesn't work right, change to array_diff_assoc
astext is too short for some

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

murrant added some commits Dec 29, 2017

fix bugs in bgp-peers poller
peer data in wrong format
array_diff doesn't work right, change to array_diff_assoc
astext is too short for some

@murrant murrant added the Bug 🐞 label Dec 29, 2017

@murrant murrant added this to the 1.35 milestone Dec 29, 2017

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Dec 29, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Member

laf commented Dec 29, 2017

Works for me. I'll keep this in mind when cutting the december release. Might not include the original code that breaks it anyway so will see. Thanks for fixing @murrant. I'll get some arista test data submitted shortly.

@laf laf merged commit c91ec38 into librenms:master Dec 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:bgp-quick-fix branch Dec 29, 2017

@laf laf added the Schema label Dec 29, 2017

@laf laf removed this from the 1.35 milestone Dec 31, 2017

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.