New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: apps lineup #7994

Merged
merged 3 commits into from Jan 5, 2018

Conversation

Projects
None yet
4 participants
@crcro
Contributor

crcro commented Jan 1, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

enabled apps overview (atm no otherway than entering the url manually)
minor display changes to match latest changes.

screen shot 2018-01-01 at 5 20 13 am

screen shot 2018-01-01 at 5 14 19 am

screen shot 2018-01-01 at 5 14 37 am

crcro added some commits Jan 1, 2018

enabled apps overview in top menu
unified apps page with new design

@kkrumm1 kkrumm1 added the WebUI label Jan 1, 2018

@@ -1,4 +1,26 @@
<?php
/*

This comment has been minimized.

@laf

laf Jan 2, 2018

Member

I've been thinking about this copyright you've added to files you've changed. I'm not 100% sure on the position but I would say that we shouldn't be adding a copyright that seems to claim it's done by LibreNMS contributors. Old historic files weren't written by us so I think you should remove this / these.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 2, 2018

The inspection completed: No new issues

@laf

This comment has been minimized.

Member

laf commented Jan 5, 2018

Overall I'm not 100% sure on the panel in panel approach but as we already have this for other pages then I'll leave it for now.

@laf laf merged commit 7460cf3 into librenms:master Jan 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@kkrumm1

This comment has been minimized.

Member

kkrumm1 commented Jan 5, 2018

@crcro I know this is off topic but anyway you could maybe look into building Overview page for Device groups?

@crcro crcro deleted the crcro:webui-apps-lineup branch Jan 6, 2018

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.