New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cisco-vrf discovery for device os junos #8009

Merged
merged 1 commit into from Jan 3, 2018

Conversation

Projects
None yet
3 participants
@zombah
Contributor

zombah commented Jan 3, 2018

Fix vrf discovery for junos devices because there is no
os_group junos right now and no need to create it as
other junos variant probably doesn't support mpls l3vpn.
This PR superseeds #8003

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: Cisco-vrf discovery for device os junos
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 3, 2018

The inspection completed: No new issues

@murrant

This comment has been minimized.

Member

murrant commented Jan 3, 2018

Thanks for researching :)

@murrant murrant merged commit da54444 into librenms:master Jan 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@zombah zombah deleted the zombah:fix-cisco-vrf branch Jan 3, 2018

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.