New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bgp-peers add missing os junos safi values #8018

Merged
merged 3 commits into from Jan 4, 2018

Conversation

Projects
None yet
4 participants
@zombah
Contributor

zombah commented Jan 3, 2018

This fixes missing safi for Junos bgp peer sessions

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: Bgp-peers add missing os junos safi values
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
@murrant

This comment has been minimized.

Member

murrant commented Jan 4, 2018

@zombah we are missing test data for bgp-peers + junos. Any chance you could try to add it with ./scripts/save-test-data.php -m bgp-peers -h HOSTNAME?

fix: Mirror cisco safi names
* Except safi 4 which is not supported by cisco
bgp mib

Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
@zombah

This comment has been minimized.

Contributor

zombah commented Jan 4, 2018

@murrant thats on my todo list, i want to create lab enviroment to produce complete snmprec for junos

@murrant

This comment has been minimized.

Member

murrant commented Jan 4, 2018

Thanks that would be great. Do you want to include it here or a separate PR?

@zombah

This comment has been minimized.

Contributor

zombah commented Jan 4, 2018

@murrant as separate PR if thats possible. It will take some time to attach and configure device to my devel libreNMS setup.

@@ -81,6 +81,9 @@
if ($device['os'] == 'junos') {
$safis[1] = 'unicast';
$safis[2] = 'multicast';
$safis[3] = 'unicastAndMulticast';
$safis[4] = 'labeledUnicast';
$safix[128] = 'vpn';

This comment has been minimized.

@murrant

murrant Jan 4, 2018

Member

Is the x in $safix a typo?

This comment has been minimized.

@zombah

zombah Jan 4, 2018

Contributor

yes, sorry. submited fix

fix typo
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 4, 2018

The inspection completed: No new issues

@laf laf merged commit 91cd338 into librenms:master Jan 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf added the Bug 🐞 label Jan 4, 2018

@zombah zombah deleted the zombah:fix-bgp-peers-junos-safi branch Jan 5, 2018

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.