New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Override -H for check_load service. Fixed backslash escaping. #8020

Merged
merged 5 commits into from Jan 8, 2018

Conversation

Projects
None yet
4 participants
@Zmegolaz
Member

Zmegolaz commented Jan 4, 2018

  • check_load does not use the -H option, and need a service file to override that.
  • I combined the load1, load5 and load15 values into one graph with multiple lines.
  • The default graph and the ICMP graph had an extra \ at the end of every GPRINT line.
  • The mysql service had an unescaped backslash.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

laf approved these changes Jan 4, 2018

I'm ok with this. Annoyingly we have no way to tell users that no matter what device they select this for it will always be local data it gets :(

Maybe a special note in https://github.com/librenms/librenms/blob/master/doc/Extensions/Services.md

@laf laf added the Bug 🐞 label Jan 4, 2018

@kkrumm1

This comment has been minimized.

Member

kkrumm1 commented Jan 5, 2018

@laf Perhaps a youtube video going over services and how they work.

Zmegolaz added some commits Jan 5, 2018

@laf

This comment has been minimized.

Member

laf commented Jan 5, 2018

@laf Perhaps a youtube video going over services and how they work.

I'll see when I get time.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 8, 2018

A new inspection was created.

@Zmegolaz Zmegolaz merged commit eac128a into librenms:master Jan 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@Zmegolaz Zmegolaz deleted the Zmegolaz:load-service branch Jan 8, 2018

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.