New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two issues with global service page #8030

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Jan 4, 2018

GROUP BY was missing a field, causing the page to not populate
Rows were missing their ID, causing them to stay there when deleted.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fix two issues with global service page
GROUP BY was missing a field, causing the page to not populate
Rows were missing their ID, causing them to stay there when deleted.
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 4, 2018

The inspection completed: No new issues

@laf laf merged commit 9b39204 into librenms:master Jan 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf added the Bug 🐞 label Jan 5, 2018

@murrant murrant deleted the murrant:services-fixes branch Jan 5, 2018

@laf laf referenced this pull request Jan 6, 2018

Merged

webui: fix services display #7993

1 of 1 task complete

crcro added a commit to crcro/librenms that referenced this pull request Jan 6, 2018

murrant added a commit that referenced this pull request Feb 8, 2018

webui: fix services display (#7993)
* fixed display bug when only one host had services

* small cleanup, renamed vars as laf change request

* message display wrongly removed, integrated back

* missed one changed line by #8030

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

webui: fix services display (librenms#7993)
* fixed display bug when only one host had services

* small cleanup, renamed vars as laf change request

* message display wrongly removed, integrated back

* missed one changed line by librenms#8030
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.