New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: AirOS version and hardware. #8034

Merged
merged 2 commits into from Jan 7, 2018

Conversation

Projects
None yet
3 participants
@Zmegolaz
Member

Zmegolaz commented Jan 5, 2018

Fix for #7996.

If anyone has more models of AirOS, please make sure all of them work. If not, please upload an snmpwalk.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@murrant

Just change this to snmp_getnext()

@murrant

This comment has been minimized.

Member

murrant commented Jan 5, 2018

Also, there is another PR for this.

@Zmegolaz

This comment has been minimized.

Member

Zmegolaz commented Jan 5, 2018

Getnext is a lot nicer, yes. :)
Which other PR?

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 5, 2018

The inspection completed: No new issues

@murrant murrant changed the title from Fix: Added more sub-oids for airos version and hardware. to Fix: AirOS version and hardware. Jan 7, 2018

@murrant murrant merged commit 4be1755 into librenms:master Jan 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@Zmegolaz Zmegolaz deleted the Zmegolaz:airos-detection branch Jan 8, 2018

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.