New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the default fping config + changed variable name #8060

merged 4 commits into from Jan 9, 2018


None yet
4 participants

laf commented Jan 9, 2018

Changed millisec to interval to match up with fping params name.
Changed default interval value to be same as timeout as code forces that anyway.
Added docs to try and explain the implications of setting a high timeout + performance docs to speed up polling.


Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.


If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

$config['fping_options']['interval'] = 500;
If you're devices are slow to respond then you will need to increase the timeout value and potentially the interval value.

This comment has been minimized.


Zmegolaz Jan 9, 2018


"you're" -> "your"

laf added some commits Jan 9, 2018


This comment has been minimized.

scrutinizer-notifier commented Jan 9, 2018

The inspection completed: 1 updated code elements

@laf laf added the Bug 🐞 label Jan 9, 2018


murrant approved these changes Jan 9, 2018

@laf laf merged commit 0a7ec12 into librenms:master Jan 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
license/cla Contributor License Agreement is signed.

@laf laf deleted the laf:fix/fping-defaults-n-docs branch Jan 9, 2018


This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.