New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Moved sysDescr snmp call to snmp_get_multi_oid() in core poller module #8062

Merged
merged 1 commit into from Jan 9, 2018

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Jan 9, 2018

This fixes the issue where discovery and poller would try and set sysDescr that varied slightly by a character return (difference between snmp_get and snmp_get_multi_oid) - this was the easier fix.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf laf added the Bug 🐞 label Jan 9, 2018

@Rosiak

Rosiak approved these changes Jan 9, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 9, 2018

The inspection completed: No new issues

@laf laf merged commit 6e134ac into librenms:master Jan 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/poller-sysdescr branch Jan 9, 2018

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.