Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve legacy Allied Telesis hardware support #8071
Refer to patch message for more details.
This patch is mostly working, with the exception of the "sysObjectId" section in includes/definitions/radlan.yaml
I've hashed it as a result. The issue is if I leave it on, generic devices will appear as "radlan" when they shouldn't.... Not sure what I'm doing wrong here.
Sorry if the code isn't pretty. I tried!
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
Thanks for that @murrant. That fixed things.
By the way - When I try run ./scripts/pre-commit.php, I just get:
Have I done something stupid, or there a bug with the pre-commit check?
Thanks for this as always.
You need to drop
+ from all the MIBs being referenced.
Also, as this will now detect more data please add some test files to cover them including the additional test data we need https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow
Thanks for all of this. I've generated the rest of the test data from your snmprec files.
When you add data for tests in future, just run