Join GitHub today
Added Dlink MIBS, memory polling and temp polling for some devices #8076
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
I don't have all the devices and FW combinations that Dlink has to offer, so the tests were done on the following devices:
System info like FW version, HW version and Serial number now displaying properly:
@hanserasmus I glanced at the data and I don't see any of the oids that hold the data
Also, if you install snmpsim, you can check the data for yourself. https://docs.librenms.org/Developing/os/Test-Units/
So in short, my current running system, on which I ran the save-test-data scripts, have all the files I have submitted, and is therefor "patched". Running
[OK] Database connection successful
I am honest in saying I may be a bit out of my depth here. I am not sure why the OID's do not match. What I do know is, if you for example look at the DGS-3120-24TC file's OID's, none of the OID's there returns a Serial Number, or a Hardware Version or FW version. But the changes I have made does display data like HW version and FW version correctly, and the temperatures are graphing as expected (with values as expected and physically seen with spot checks on the devices). I know this may not be good enough for keeping the code up to standard, and I understand that, but at the moment I have no other explanation.
@laf Thank you for this clear and precise indications of what you needed. I have made all the changes to the code you have commented on. I have not submitted it yet, I have just "patched" my current install with all the changes, and then ran the tests against that. I have done the snmpsim install as well now, so I am adding the json file for that result as well.
Only thing that happened was, after I have made the changes to the files, and ran the test script, my historic temperature data (and ONLY temperature data) in the graphs disappeared for the device (ID 14) on which I ran the test. It now just shows current temperature, and "nan" in the historic graphs. Don't know if I broke something, or if it is just coincidence. All other devices are still running as expected and graphing as expected (with a glance over).
Thanks again for the help and the trouble, I appreciate it!
Is it still showing NaN?