New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Synology Hardware/Version/Serial detection #8087

Merged
merged 9 commits into from Jan 21, 2018

Conversation

Projects
None yet
4 participants
@peelman
Contributor

peelman commented Jan 15, 2018

Fixes #7957

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@murrant

This comment has been minimized.

Member

murrant commented Jan 16, 2018

Would you be willing to add test data for this?

https://docs.librenms.org/Developing/os/Test-Units/

@peelman

This comment has been minimized.

Contributor

peelman commented Jan 16, 2018

@murrant like that?

@laf

This comment has been minimized.

Member

laf commented Jan 17, 2018

Close :)

It's got the data we need but it also needed some json data generating off the back of it. I've done that in this branch for you so you can check the changes and see what's different. Just an FYI, your install is way out of date so didn't include the script to generate this test data anyway - you should upgrade :)

@laf

laf approved these changes Jan 17, 2018

@peelman

This comment has been minimized.

Contributor

peelman commented Jan 17, 2018

Yeah I noticed that after I pushed. Has since been corrected.

Later today, I will similarly fix #8086 based off of your example here. Thanks!

laf and others added some commits Jan 17, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 21, 2018

The inspection completed: No new issues

@murrant murrant merged commit 9ee96bd into librenms:master Jan 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant added the Device 🖥 label Jan 21, 2018

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.