New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: new EER and Water Flow Rate sensors #8104

Merged
merged 5 commits into from Jan 18, 2018

Conversation

Projects
None yet
3 participants
@FTBZ
Contributor

FTBZ commented Jan 17, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


Progress:

  • Added EER sensor (Energy Efficiency Ratio)
  • Added Water Flow Rate sensor
  • Added Water Flow Rate to Rittal Chiller device
  • Added EER to Rittal Chiller device

screen shot 2018-01-18 at 06 59 14

@laf

This comment has been minimized.

Member

laf commented Jan 17, 2018

Thanks for this @FTBZ.

Can you also generate test data for this device? Run ./scripts/save-test-data.php -h ID with the ID of the device. Check the data to make sure nothing sensitive is in it.

@laf laf added the Feature label Jan 17, 2018

@FTBZ FTBZ changed the title from feature: new sensors to feature: new EER and Water Flow Rate sensors Jan 18, 2018

@FTBZ

This comment has been minimized.

Contributor

FTBZ commented Jan 18, 2018

@laf Snmprec file is now completed and PR ready for a code review.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 18, 2018

The inspection completed: No new issues

@laf

This comment has been minimized.

Member

laf commented Jan 18, 2018

Awesome work @FTBZ :)

I generated the json test data for you by running ./scripts/save-test-data.php -o pcoweb-rittalchiller -m os,sensors

Not sure how you got the snmprec file in but the save-test-data.php script should deal with it all for you. Check the docs on it.

@laf laf merged commit c80f972 into librenms:master Jan 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.