New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: Add Allied Telesis CPU info #8111

Merged
merged 1 commit into from Jan 18, 2018

Conversation

Projects
None yet
3 participants
@mattie47
Contributor

mattie47 commented Jan 18, 2018

Added support to poll both standalone devices and VCStacked device's CPU info.


This works, however I don't like that on the device summary it shows the last polled CPU (e.g. CPU 8 in a stack of 8 switches), as usually the stack master will be stack member 1:

image

Can you see a way of modifying what I have (which I mostly copied from acos.inc.php) so Processor 1 will be what is shows on the device summary page?

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

device: Add Allied Telesis CPU info
Added support to poll both standalone devices and VCStacked
device's CPU info
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 18, 2018

The inspection completed: No new issues

@laf laf merged commit 1da86aa into librenms:master Jan 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf added the Device 🖥 label Jan 18, 2018

@laf

This comment has been minimized.

Member

laf commented Jan 18, 2018

Can you see a way of modifying what I have (which I mostly copied from acos.inc.php) so Processor 1 will be what is shows on the device summary page?

That happens for all devices, it's not specific to this. It basically shows the last cpus description whilst aggregating all the data.

@mattie47 mattie47 deleted the mattie47:allied-cpu branch Jan 19, 2018

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.