New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: Fix awplus $hardware for certain products #8123

Merged
merged 1 commit into from Jan 22, 2018

Conversation

Projects
None yet
3 participants
@mattie47
Contributor

mattie47 commented Jan 22, 2018

awplus.inc.php uses snmpgetnext for $hardware.

This works well for 99% of products however chassis
product SBx8100 does not show the chassis as the first product.

This adds an exception to follow for this product

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

device: Fix awplus $hardware for certain products
awplus.inc.php uses snmpgetnext for $hardware.

This works well for 99% of products however chassis
product SBx8100 does not show the chassis as the first product.

This adds an exception to follow for this product
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 22, 2018

The inspection completed: No new issues

@mattie47

This comment has been minimized.

Contributor

mattie47 commented Jan 22, 2018

So this makes the following work for the 6 slot chassis and 12 slot chassis:

image

image

@mattie47

This comment has been minimized.

Contributor

mattie47 commented Jan 22, 2018

Why not use sysObjectID.0 for all platforms?

Because BoardID has a slightly nicer formatted name across all platforms than what is returned by sysObjectID.

The SBx8100 is also the only awplus chassis product at present.

@laf laf merged commit fbca432 into librenms:master Jan 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@mattie47 mattie47 deleted the mattie47:patch1 branch Feb 12, 2018

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.