New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: add suspended state to PAN OS #8125

Merged
merged 2 commits into from Jan 25, 2018

Conversation

Projects
None yet
4 participants
@FTBZ
Contributor

FTBZ commented Jan 22, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


  • Add "Suspended" state to Palo Alto Networks firewalls
@@ -276,10 +276,6 @@
"rule": "%devices.os = \"nxos\" && %sensors.sensor_type = \"cefcFanTrayOperStatus\" && %sensors.sensor_current = \"[3-4]\"",
"name": "Cisco NX-OS device has a bad fan"
},
{

This comment has been minimized.

@laf

laf Jan 22, 2018

Member

Any reason this was removed, it should be valid still as it checks that the previous state was passive but is not active.

This comment has been minimized.

@FTBZ

FTBZ Jan 23, 2018

Contributor

The rule was tested in deep yesterday and no way to match it and I didn't find a way to make it work. Don't understand why but since this is an important one I prefer to remove it to prevent users from using it if it's not working.

@kkrumm1

This comment has been minimized.

Member

kkrumm1 commented Jan 23, 2018

@FTBZ #8138

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 23, 2018

The inspection completed: No new issues

@laf laf merged commit 2755763 into librenms:master Jan 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.