New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palo Alto HA Alert Rule references non-existent column in sensors table #8138

Merged
merged 1 commit into from Jan 24, 2018

Conversation

Projects
None yet
6 participants
@chipgwyn
Copy link
Contributor

chipgwyn commented Jan 23, 2018

The "Palo Alto Networks passive firewall changed to active" alert rule references the "type"

column in the sensors table. However there is no "type" column. This should be "sensor_type". This is indicated
by the error in the logs:

MySQL Error: Unknown column 'sensors.type' in 'where clause' (SELECT * FROM devices,sensors WHERE (( sensors.device_id = devices.device_id ) && devices.device_id = '102') && (devices.os = "panos" & sensors.type = "panSysHAState" && sensors.sensor_current = "1" && sensors.sensor_prev = "2" ))

Updated the rule to reference the correct column.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

The "**Palo Alto Networks passive firewall changed to active**" alert…
… rule references the "type"

column in the sensors table.  However there is no "type" column.  This should be "sensor_type".  This is indicated
by the error in the logs:

`MySQL Error: Unknown column 'sensors.type' in 'where clause' (SELECT * FROM devices,sensors WHERE (( sensors.device_id = devices.device_id ) && devices.device_id = '102') && (devices.os = "panos" & sensors.type = "panSysHAState"  &&  sensors.sensor_current = "1"  &&  sensors.sensor_prev = "2"  ))
`

Updated the rule to reference the correct column.
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Jan 23, 2018

CLA assistant check
All committers have signed the CLA.

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Jan 23, 2018

The inspection completed: No new issues

@kkrumm1 kkrumm1 referenced this pull request Jan 23, 2018

Merged

device: add suspended state to PAN OS #8125

1 of 1 task complete
@FTBZ

This comment has been minimized.

Copy link
Contributor

FTBZ commented Jan 23, 2018

Excellent, thanks. 👍🏻

@laf laf merged commit f2088a5 into librenms:master Jan 24, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf added the Bug 🐞 label Jan 24, 2018

@laf

This comment has been minimized.

Copy link
Member

laf commented Jan 24, 2018

Well spotted :)

@lock

This comment has been minimized.

Copy link

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.