New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: Implement Allied Telesis Environmental Monitoring #8140

Merged
merged 11 commits into from Feb 14, 2018

Conversation

Projects
None yet
4 participants
@mattie47
Contributor

mattie47 commented Jan 24, 2018

Initial patch to monitor:

  • fans
  • temperature

State:

  • fans
  • temperature

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

device: Implement Allied Telesis Environmental Monitoring
Initial patch to monitor:
- fans
- temperature

State:
- fans
- temperature
@mattie47

This comment has been minimized.

Contributor

mattie47 commented Jan 24, 2018

I'm still working on this.... More to come.

@laf laf added the Blocker 🚫 label Jan 24, 2018

@laf

This comment has been minimized.

Member

laf commented Jan 24, 2018

Let us know when it's done and we can remove the blocker tag and review.

@mattie47

This comment has been minimized.

Contributor

mattie47 commented Jan 29, 2018

@laf Ready.

This implements basic monitoring of:

  • Fan Speed and State
  • Voltage Speed and State
  • Temperature and State
  • Power Supply State

I may look at doing things like pluggable monitoring later but the above additions are good in their current state. Have tested on most platforms.

device: Implement Allied Telesis Environmental Monitoring
Patches cover:

- Fan Speed and State
- Voltage Speed and State
- Temperature and State
- Power Supply State
@murrant

This comment has been minimized.

Member

murrant commented Jan 30, 2018

@mattie47 Looks good would be great if you added test data for this:
https://docs.librenms.org/Developing/os/Test-Units/#capturing-test-data

just do the sensors module

@mattie47

This comment has been minimized.

Contributor

mattie47 commented Jan 30, 2018

@murrant Thanks. Sorry, I didn't realise I need to do that again.

I've updated the test data, but I possibly still haven't done it in the desired json format. I'm still having issues with that:

librenms@librenmsdev:~$ nano /opt/librenms/tests/snmpsim/awplus.snmprec
librenms@librenmsdev:~$ ./scripts/save-test-data.php -o awplus -m sensors
Starting snmpsim listening on 127.1.6.1:1161... 
OS: awplus
Module: sensors

awplus: Could not connect to 127.1.6.1, please check the snmp details and snmp reachability

librenms@librenmsdev:~$ ./scripts/pre-commit.php -p -u
Running unit tests... 
PHP Fatal error:  Uncaught Error: Class 'PHPUnit_TextUI_Command' not found in /opt/librenms/vendor/phpunit/phpunit/phpunit:52
Stack trace:
#0 {main}
  thrown in /opt/librenms/vendor/phpunit/phpunit/phpunit on line 52
@murrant

This comment has been minimized.

Member

murrant commented Feb 8, 2018

@mattie47 I've checked the snmprec and it doesn't seem to contain data for the new sensors.

You may have a corrupt snmprec file or something.

Try running ./scripts/collect-snmp-data.php --snmpsim

@mattie47

This comment has been minimized.

Contributor

mattie47 commented Feb 12, 2018

@murrant

Thanks for that.

I came back today and had a look at this again and realised I'd managed to install an older version of snmpsim (snmpsim-0.2.4) which is why I never got the tests working properly...

Having now installed it via pip I'll get the test data done properly...

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 13, 2018

The inspection completed: No new issues

@mattie47

This comment has been minimized.

Contributor

mattie47 commented Feb 13, 2018

@murrant

Sorry this has taken a while...

I think I've got everything right now, and I've also updated the snmprec data for all the sensors and processors. I think it's all correct :-)

Thanks,

Matt

@murrant murrant merged commit 4a0acad into librenms:master Feb 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant added Device 🖥 and removed Blocker 🚫 labels Feb 14, 2018

@mattie47 mattie47 deleted the mattie47:patch3 branch Feb 14, 2018

wiad pushed a commit to wiad/librenms that referenced this pull request Feb 23, 2018

device: Implement Allied Telesis Environmental Monitoring (librenms#8140
)

* device: Implement Allied Telesis Environmental Monitoring

Initial patch to monitor:
- fans
- temperature

State:
- fans
- temperature

* device: Implement Allied Telesis Environmental Monitoring

Patches cover:

- Fan Speed and State
- Voltage Speed and State
- Temperature and State
- Power Supply State

* updated awplus test data

* Update awplus sensors and snmprec test data

* Add awplus processor snmprec stats

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

device: Implement Allied Telesis Environmental Monitoring (librenms#8140
)

* device: Implement Allied Telesis Environmental Monitoring

Initial patch to monitor:
- fans
- temperature

State:
- fans
- temperature

* device: Implement Allied Telesis Environmental Monitoring

Patches cover:

- Fan Speed and State
- Voltage Speed and State
- Temperature and State
- Power Supply State

* updated awplus test data

* Update awplus sensors and snmprec test data

* Add awplus processor snmprec stats
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.