Updated Cisco detection #815

Merged
merged 2 commits into from Apr 16, 2015

Projects

None yet

2 participants

@laf
Member
laf commented Apr 15, 2015

Ok so this includes:

  1. Update to the regex that matches the cisco sysDescr. This didn't match one particular example but this should be backwards compatible.
  2. We try and split the $version variable again to deal with this new format and if the result ends up with a variable still set then this is used as the version number.
  3. Before entPhysicalName is used, it's also checked if it's "Switch System". If it is then it skips assigning it as a variable so it can fall back to other methods.

I've tested this across two full discovery runs and all my Cisco devices are fine:

ASA firewalls
2960,3750x,Nexus 3/5/7ks
ASRs
6500s

All fine. @SaaldjorMike tested this patch specifically on a 4500x which is why it was updated and confirm this now works for him.

@f0o
Member
f0o commented Apr 16, 2015

Do you mind squashing the commits together and resubmitting please?
Commit log looks much nicer then :)

@f0o
Member
f0o commented Apr 16, 2015

Related #794

@laf
Member
laf commented Apr 16, 2015

Done

@f0o f0o merged commit 6472fdd into librenms:master Apr 16, 2015

1 check passed

Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment