New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed is_file to rrdtool_check_rrd_exists in php-fpm and squid applications graphs. #8152

Merged
merged 5 commits into from Jan 26, 2018

Conversation

Projects
None yet
5 participants
@leandrojmp
Contributor

leandrojmp commented Jan 26, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


I ran into an issue where the webserver was not talking to the RRDCached server to plot some application graphs, php-fpm and squid, investigating I found that the webserver was looking for the file locally.

Changed the is_file function to the rrdtool_check_rrd_exists function in the php scripts that generate the graphics for php-fpm and squid.

leandrojmp added some commits Jan 26, 2018

@CLAassistant

This comment has been minimized.

CLAassistant commented Jan 26, 2018

CLA assistant check
All committers have signed the CLA.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Jan 26, 2018

The inspection completed: No new issues

@laf laf merged commit e953082 into librenms:master Jan 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.