New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: "DEVELOP" Support #8153

Merged
merged 3 commits into from Mar 17, 2018

Conversation

Projects
None yet
6 participants
@jasoncheng7115
Contributor

jasoncheng7115 commented Jan 26, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

CLAassistant commented Jan 26, 2018

CLA assistant check
All committers have signed the CLA.

@jasoncheng7115

This comment has been minimized.

Contributor

jasoncheng7115 commented Jan 26, 2018

the "DEVELOP ineo+" type is fork by KONICA MINOLTA.

@kkrumm1

This comment has been minimized.

Member

kkrumm1 commented Jan 26, 2018

@jasoncheng7115 why did you delete everything below "DO NOT DELETE THIS TEXT" ?

@jasoncheng7115

This comment has been minimized.

Contributor

jasoncheng7115 commented Jan 26, 2018

Hooo...... Sorry, it's my mistake, i have fixed it.

@murrant

This comment has been minimized.

Member

murrant commented Jan 26, 2018

@jasoncheng7115 your indentation is off, please fix that (tabs instead of spaces maybe?)

@jasoncheng7115

This comment has been minimized.

Contributor

jasoncheng7115 commented Jan 26, 2018

@murrant thank your tip, i fixed it. :-)

@laf

This comment has been minimized.

Member

laf commented Jan 26, 2018

Thanks for submitting this @jasoncheng7115

We will need test data as well so that we can ensure this change doesn't become broken in the future.

@laf laf added the Blocker 🚫 label Jan 26, 2018

@murrant

This comment has been minimized.

@laf

This comment has been minimized.

Member

laf commented Feb 18, 2018

@jasoncheng7115 Any update on this one?

@jasoncheng7115

This comment has been minimized.

Contributor

jasoncheng7115 commented Feb 21, 2018

Hello!

Thanks for the tips,
run "collect-snmp-data.php" is ok.


./scripts/collect-snmp-data.php -h 9 -m os

OS: konica
Module(s): os

Capturing Data: sysDescr.0 sysObjectID.0 sysName.0 SNMPv2-MIB::sysDescr.0 SNMPv2-MIB::sysObjectID.0 .1.3.6.1.4.1.12148.10.2.6.0 sysUpTime.0 sysLocation.0 sysContact.0 snmpEngineTime.0 > hrSystemUptime.0 1.3.6.1.4.1.18334.1.1.1.1.6.2.1.0 1.3.6.1.4.1.18334.1.1.1.1.6.1.0

Updated snmprec data /opt/librenms/tests/snmpsim/konica.snmprec

Verify this file does not contain any private data before submitting!


cat /opt/librenms/tests/snmpsim/konica.snmprec

1.3.6.1.2.1.1.1.0|4|KONICA MINOLTA bizhub C3110
1.3.6.1.2.1.1.2.0|6|1.3.6.1.4.1.18334.1.1.1.2.1.117.2.2
1.3.6.1.2.1.1.3.0|67|173664643
1.3.6.1.2.1.1.4.0|4|
1.3.6.1.2.1.1.5.0|4|
1.3.6.1.2.1.1.6.0|4|
1.3.6.1.2.1.25.1.1.0|67|173664647
1.3.6.1.4.1.18334.1.1.1.1.6.1.0|4|1.80
1.3.6.1.4.1.18334.1.1.1.1.6.2.1.0|4|Develop ineo+ 280

@jasoncheng7115

This comment has been minimized.

Contributor

jasoncheng7115 commented Feb 21, 2018

But I run "pre-commit.php"This question appears:

./scripts/pre-commit.php --db --snmpsim

Running unit tests... Timeout: No Response from udp:127.1.6.2:1161.

I try to modify the file ip = 127.0.0.1, get same output:

./scripts/pre-commit.php --db --snmpsim

Running unit tests... Timeout: No Response from udp:127.0.0.1:1161.

how can I solve? please help me, thank you!

@laf

This comment has been minimized.

Member

laf commented Feb 27, 2018

Don't worry about the pre-commit. Just run ./scripts/save-test-data.php -o konica -m os add the new files to this pr and we should be good.

@jasoncheng7115

This comment has been minimized.

Contributor

jasoncheng7115 commented Mar 1, 2018

I run ./scripts/save-test-data.php -o konica -m os , The results:

root@mon:/opt/librenms# ./scripts/save-test-data.php -o konica -m os
Starting snmpsim listening on 127.1.6.1:1161...
OS: konica
Module: os

konica: Could not connect to 127.1.6.1, please check the snmp details and snmp reachability

hoo..

@laf

This comment has been minimized.

Member

laf commented Mar 8, 2018

Sorry for the delay. Please run ./scripts/collect-snmp-data.php -h $HOSTNAME instead and upload the file to this PR that it produces, we'll take a look after that.

@jasoncheng7115

This comment has been minimized.

Contributor

jasoncheng7115 commented Mar 14, 2018

Thanks for your help. I have uploaded my file here.
Yeah!

konica.zip

jasoncheng7115 and others added some commits Jan 26, 2018

device: "DEVELOP" Support
support "DEVELOP", it's fork by KONICA MINOLTA.

@murrant murrant added Device 🖥 and removed Blocker 🚫 labels Mar 17, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 17, 2018

The inspection completed: No new issues

@murrant murrant merged commit a570165 into librenms:master Mar 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

device: "DEVELOP" Support (librenms#8153)
* device: "DEVELOP" Support 

support "DEVELOP", it's fork by KONICA MINOLTA.

* Update konica.yaml

* Add tests
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.