Datacom basic support added with snmp Mibs #816

Merged
merged 2 commits into from Apr 15, 2015

Projects

None yet

2 participants

@alangregory
Contributor

I think it's righ now.

@laf
Member
laf commented Apr 15, 2015

Nearly :)

You're missing your processor files for discovery and processor. And also the polling/os/datacom.inc.php is just the discovery file again, your other PR was correct.

No need to close this PR, just add those files and replace the one mentioned then commit these and you'll be good to go.

@laf laf self-assigned this Apr 15, 2015
@laf laf added the enhancement label Apr 15, 2015
@laf
Member
laf commented Apr 15, 2015

All looks good to me.

@laf laf merged commit a3568f5 into librenms:master Apr 15, 2015

1 check passed

Scrutinizer 6 new issues
Details
@alangregory alangregory deleted the unknown repository branch Apr 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment