New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share code between all mysql based authorizers #8174

Merged
merged 2 commits into from Feb 6, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Jan 30, 2018

I plan to update the mysql password encryption and this will allow the code to be changed in a single location.
It also reduces a lot of duplication.

Tested MySQL and ActiveDirectory.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

murrant added some commits Jan 30, 2018

Share code between all mysql based authorizers
I plan to update the mysql password encryption and this will allow the code to be changed in a single location.
It also reduces a lot of duplication.
Fix tests, I suspect reauthenticate will work for these...
Do not allow password updates for several authorizers
@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 1, 2018

The inspection completed: 7 new issues, 4 updated code elements

@murrant murrant added the Refactor label Feb 2, 2018

@laf laf merged commit 5141fc4 into librenms:master Feb 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:authentication-refactor branch Feb 7, 2018

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

refactor: Share code between all mysql based authorizers (librenms#8174)
* Share code between all mysql based authorizers
I plan to update the mysql password encryption and this will allow the code to be changed in a single location.
It also reduces a lot of duplication.

* Fix tests, I suspect reauthenticate will work for these...
Do not allow password updates for several authorizers
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.