New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update awplus to new processor discovery #8204

Merged
merged 2 commits into from Feb 6, 2018

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Feb 6, 2018

Have no test data, so this needs testing.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

murrant and others added some commits Feb 6, 2018

Update awplus to new processor discovery
Have no test data, so this needs testing.
@laf

This comment has been minimized.

Member

laf commented Feb 6, 2018

I'm fine with merging this, going off the code along the index and oids will stay the same so no loss in data.

I've resolved the test failure so this should be good for a merge when travis finishes.

@laf laf added the Refactor label Feb 6, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 6, 2018

The inspection completed: 712 Issues, 37 Patches

@laf laf merged commit 913d6dc into librenms:master Feb 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@mattie47

This comment has been minimized.

Contributor

mattie47 commented Feb 13, 2018

I've added processor test data under d6e86bc

Thanks,

Matt

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

refactor: Update awplus to new processor discovery (librenms#8204)
* Update awplus to new processor discovery
Have no test data, so this needs testing.

* Updated YamlTest to include data as optional param for processors
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.