New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: Add XOS X480 and X650 desc and tests #8206

Merged
merged 6 commits into from Feb 7, 2018

Conversation

Projects
None yet
4 participants
@zombah
Contributor

zombah commented Feb 6, 2018

Signed-off-by: Misha Komarovskiy zombah@gmail.com

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

device: Add XOS X480 and X650 desc and tests
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
@laf

This comment has been minimized.

Member

laf commented Feb 6, 2018

@zombah Thanks for this. You will also need to generate the json files for this test data: https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow

device: add XOS x480 and x650 test data
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
@zombah

This comment has been minimized.

Contributor

zombah commented Feb 7, 2018

Ops, missed them. Now added.

murrant added some commits Feb 7, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 7, 2018

The inspection completed: No new issues

@murrant murrant merged commit 26ce852 into librenms:master Feb 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant added the Device 🖥 label Feb 7, 2018

@zombah zombah deleted the zombah:xos-x480-x650 branch Feb 7, 2018

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

device: Add XOS X480 and X650 desc and tests (librenms#8206)
* device: Add XOS X480 and X650 desc and tests

Signed-off-by: Misha Komarovskiy <zombah@gmail.com>

* device: add XOS x480 and x650 test data

Signed-off-by: Misha Komarovskiy <zombah@gmail.com>

* Add missing hardware string in test data
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.