New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add History to Billing API Functions #8209

Merged
merged 2 commits into from Feb 9, 2018

Conversation

Projects
None yet
4 participants
@richardlawley
Contributor

richardlawley commented Feb 6, 2018

This PR introduces history functions for billing in the API. It enables:

  • /api/v0/bills?period=previous - billing list for previous completed period (same as selecting "Previous Billing Period" in UI)
  • /api/v0/bills/1?period=previous - as above, with single bill selected
  • /api/v0/bills/1/history - retrieve all history data for the selected bill

This brings some parity between information available in the UI and information in the API.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 6, 2018

The inspection completed: 2 updated code elements

@murrant

murrant approved these changes Feb 7, 2018

@laf laf merged commit 2018c9f into librenms:master Feb 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

api: Added History to Billing API Functions (librenms#8209)
* Add Previous Period options to Bill API functions

* Add Bill History API Functions
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.