New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for OpenBSD PF states #8211

Merged
merged 9 commits into from Feb 8, 2018

Conversation

Projects
None yet
5 participants
@dagmartin
Contributor

dagmartin commented Feb 6, 2018

This adds graphs for PF firewall state table on OpenBSD (might apply to FreeBSD as well, have not tested)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

CLAassistant commented Feb 6, 2018

CLA assistant check
All committers have signed the CLA.

@murrant

This comment has been minimized.

Member

murrant commented Feb 7, 2018

Perhaps you should drop openbsd_ from the graph names?

@dagmartin

This comment has been minimized.

Contributor

dagmartin commented Feb 7, 2018

I wasn't really sure about the naming convention, most other related graphs I looked at seemed to have the vendor name in the filename (panos, fortios, etc.) and just "pf" might seem a bit generic? Since I've only tested this against OpenBSD I thought it made sense to name the files like that, but I'm happy to change if that is desired.

@murrant

This comment has been minimized.

Member

murrant commented Feb 8, 2018

@dagmartin even if the data collection is different, won't the data and graphs be the same?

@dagmartin

This comment has been minimized.

Contributor

dagmartin commented Feb 8, 2018

That's true. I've removed the openbsd prefix from the files.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 8, 2018

The inspection completed: No new issues

@laf laf merged commit 2bd88a2 into librenms:master Feb 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

device: Added support for OpenBSD PF states (librenms#8211)
* First basic support for graphing openbsd pf states

* Now openbsd pf state graphing actually works

* First basic support for graphing openbsd pf states

* Now openbsd pf state graphing actually works

* Wrong graph types for searches, removals and inserts

* Removed unused file "openbsd_pfstates.inc.php"

* Remove openbsd from filenames, make it more generic
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.