New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow frameborder attribute in notes widget #8219

Merged
merged 1 commit into from Feb 8, 2018

Conversation

Projects
None yet
5 participants
@MrMaus13
Contributor

MrMaus13 commented Feb 7, 2018

Allow for iframe border removal by allowing frameborder attribute.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Update notes.inc.php
Allow from iframe border removal by allowing frameborder attribute.
@CLAassistant

This comment has been minimized.

CLAassistant commented Feb 7, 2018

CLA assistant check
All committers have signed the CLA.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 7, 2018

The inspection completed: No new issues

@murrant

This comment has been minimized.

Member

murrant commented Feb 8, 2018

Can you explain the results of this a bit more?
Perhaps a screenshot would be helpful too.

@MrMaus13

This comment has been minimized.

Contributor

MrMaus13 commented Feb 8, 2018

The notes-widget can be used to add all sorts of things to your dashboard, including iframes.
This is a handy feature because it allows you to add some content to your dashboard from external sources but also from, for example, the weathermap plugin.

If you add an iframe like this:
<iframe src="your_url" width="100%" height = "100%">

It looks like this:
note_border

Allowing the frameborder attribute you can remove the border, it's just for esthetic purposes;
<iframe src="your_url" frameBorder="0" width="100%" height = "100%">

It then looks like this:
note_borderless

@murrant

This comment has been minimized.

Member

murrant commented Feb 8, 2018

Thanks, wasn't sure :)

@murrant murrant merged commit 1cdb37d into librenms:master Feb 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant added the WebUI label Feb 8, 2018

@murrant murrant changed the title from Update notes.inc.php to Allow frameborder attribute in notes widget Feb 8, 2018

@kkrumm1

This comment has been minimized.

Member

kkrumm1 commented Feb 8, 2018

Very nice thank you @MrMaus13

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

Update notes.inc.php (librenms#8219)
Allow from iframe border removal by allowing frameborder attribute.
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.