New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding invalid hostnames is no longer fatal. #8233

Merged
merged 2 commits into from Feb 9, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Feb 8, 2018

Will still fail if they are unpingable.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Adding invalid hostnames is no longer fatal.
Will still fail if they are unpingable.

@murrant murrant added the WebUI label Feb 8, 2018

@laf

This comment has been minimized.

Member

laf commented Feb 8, 2018

This disables snmp by default so users would add ping only devices.

Not really sure what the difference is, from testing adding some fake devices I don't see what's changed.

@murrant

This comment has been minimized.

Member

murrant commented Feb 8, 2018

When I tested snmp was not disabled by default. I'll retest that.

Before, if the hostname was invalid, it would not try to ping it.

Now, it still shows an error, but it tries to ping/add it anyway.

This was for the user with underscores in his hostnames.

@laf

This comment has been minimized.

Member

laf commented Feb 8, 2018

This was for the user with underscores in his hostnames.

Is it not easier just to update the validation?

@murrant

This comment has been minimized.

Member

murrant commented Feb 8, 2018

The validation is correct in my opinion.

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 9, 2018

The inspection completed: No new issues

@laf laf merged commit 9cc542b into librenms:master Feb 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:invalid_hostname branch Feb 9, 2018

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

webui: Adding invalid hostnames is no longer fatal. (librenms#8233)
* Adding invalid hostnames is no longer fatal.
Will still fail if they are unpingable.

* Fix up snmp enable/disable handling
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.