New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Unused Billing PDF reports #8235

Merged
merged 1 commit into from Feb 8, 2018

Conversation

Projects
None yet
3 participants
@richardlawley
Contributor

richardlawley commented Feb 8, 2018

As discussed on discord, these pages are not accessible from anywhere and have been broken since before March 2015. Link from the UI removed in #146, and code to get to it from html/pdf.php removed in #653.

Since it hasn't been working for years and nobody has complained, removing it rather than fixing something hardly anyone knew existed!

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 8, 2018

The inspection completed: No new issues

@laf laf merged commit 763c86f into librenms:master Feb 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.