New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with new config init #8242

Merged
merged 2 commits into from Feb 12, 2018

Conversation

Projects
None yet
3 participants
@murrant
Copy link
Member

murrant commented Feb 11, 2018

non $config variables defined in defaults.inc.php are no longer global, move them into $config.
include process_config.php changes since merge and delete file

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

murrant added some commits Feb 11, 2018

@murrant murrant added the Bug 🐞 label Feb 11, 2018

@murrant murrant changed the title Fix non-config defaults Fix issues with new config init Feb 11, 2018

@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Feb 11, 2018

The inspection completed: No new issues

@@ -1,61 +0,0 @@
<?php

This comment has been minimized.

@laf

laf Feb 11, 2018

Member

How come all of this file has been removed?

This comment has been minimized.

@murrant

murrant Feb 12, 2018

Author Member

Its replacement is inside Config.php and process_config.inc.php is never called right now.

@laf laf merged commit 561846a into librenms:master Feb 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:config-fixes branch Feb 12, 2018

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

fix: Fiedx issues with new config init (librenms#8242)
* Fix non-config defaults

* update processConfig and remove file
@lock

This comment has been minimized.

Copy link

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.