Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LDAP filter in the getUserlist() function #8253

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
4 participants
@pep-un
Copy link
Contributor

pep-un commented Feb 14, 2018

Improve LDAP filtering to improve the speed of some pages (Dashboard and
Edit User mainly). If we don't apply this filter all the users are getted
from LDAP and used in to the loop, with 2k users (for us) the page take
more than 15 seconds to be loaded.

I have check than people still have differante access with this fix.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Improve LDAP filter in the getUserlist() function
Improve LDAP filtering to improve the speed of some pages (Dashboard and
Edit User mainly). If we don't apply this filter all the users are getted
from LDAP and used in to the loop, with 2k users (for us) the page take
more than 15 seconds to be loaded.

I have check than people still have differante access with this fix.
@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Feb 14, 2018

The inspection completed: No new issues

@laf

laf approved these changes Feb 18, 2018

@pep-un

This comment has been minimized.

Copy link
Contributor Author

pep-un commented Feb 23, 2018

Hi guys,
will it be merged for the next release ?
Best regards,

@f0o

f0o approved these changes Feb 23, 2018

@f0o

This comment has been minimized.

Copy link
Member

f0o commented Feb 23, 2018

I think we can merge this, it looks good and it worked in my test-env :)

@laf

This comment has been minimized.

Copy link
Member

laf commented Feb 27, 2018

Yeah sorry it wasn't going to make it into the lsat release.

I've just tagged someone in on discord to test this as well and then we'll merge.

@laf laf added the Bug 🐞 label Feb 27, 2018

@laf

This comment has been minimized.

Copy link
Member

laf commented Mar 9, 2018

No feedback from the other user. Merging in as code looks sane.

@laf laf merged commit 0e09e09 into librenms:master Mar 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

bug: Improve LDAP filter in the getUserlist() function (librenms#8253)
Improve LDAP filtering to improve the speed of some pages (Dashboard and
Edit User mainly). If we don't apply this filter all the users are getted
from LDAP and used in to the loop, with 2k users (for us) the page take
more than 15 seconds to be loaded.

I have check than people still have differante access with this fix.
@lock

This comment has been minimized.

Copy link

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.