New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bgp peers discovery cleanup #8263

Merged
merged 1 commit into from Feb 19, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Feb 18, 2018

Take context into account, update index for that

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fix bgp peers discovery cleanup
Take context into account, update index for that

@murrant murrant added the Bug 🐞 label Feb 18, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 18, 2018

The inspection completed: No new issues

dbDelete(
'bgpPeers_cbgp',
'`device_id`=? AND `bgpPeerIdentifier`=? AND context_name=? AND afi=? AND safi=?',
[$device['device_id'], $peer['ip'], $device['context_name'], $afi, $safi]

This comment has been minimized.

@laf

laf Feb 18, 2018

Member

Is that the first time we've had an array shorthand in since the split :D

This comment has been minimized.

@murrant

murrant Feb 19, 2018

Member

No, there is some in the processor code I think. Not ready for a mass replace, but I figured I might as well use it in new/changed code. New is probably safer in case we need to backport.

@laf

This comment has been minimized.

Member

laf commented Feb 18, 2018

I can only test this on Arista. Works fine for those devices.

@laf

laf approved these changes Feb 18, 2018

@murrant

This comment has been minimized.

Member

murrant commented Feb 19, 2018

I tested it with several models using the test data.

@murrant murrant merged commit 1c5b9d3 into librenms:master Feb 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fix-bgp-discovery-cleanup branch Feb 19, 2018

wiad pushed a commit to wiad/librenms that referenced this pull request Feb 23, 2018

Fix bgp peers discovery cleanup (librenms#8263)
Take context into account, update index for that

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

Fix bgp peers discovery cleanup (librenms#8263)
Take context into account, update index for that
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.