New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ScreenOS arp tables #8273

Merged
merged 1 commit into from Feb 22, 2018

Conversation

Projects
None yet
4 participants
@murrant
Copy link
Member

murrant commented Feb 21, 2018

Has a buggy implementation of ipNetToMediaPhysAddress

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Add support for ScreenOS arp tables
Has a buggy implementation of ipNetToMediaPhysAddress
@scrutinizer-notifier

This comment has been minimized.

Copy link

scrutinizer-notifier commented Feb 21, 2018

The inspection completed: No new issues

@leandrojmp

This comment has been minimized.

Copy link
Contributor

leandrojmp commented Feb 21, 2018

Hello,

I've just tested the screenos.inc.php and run discovery.php for three screenos devices and it worked for all of them, librenms can now generate the arp table for the screenos devices.

Thanks!

@laf laf added the Device 🖥 label Feb 22, 2018

@laf laf merged commit a6f6e4d into librenms:master Feb 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Copy link
Member

laf commented Feb 22, 2018

Hello,

I've just tested the screenos.inc.php and run discovery.php for three screenos devices and it worked for all of them, librenms can now generate the arp table for the screenos devices.

Thanks!

That works for me :)

Thanks @murrant as always

@murrant murrant deleted the murrant:screenos-arp branch Feb 22, 2018

wiad pushed a commit to wiad/librenms that referenced this pull request Feb 23, 2018

device: Added support for ScreenOS arp tables (librenms#8273)
Has a buggy implementation of ipNetToMediaPhysAddress

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

device: Added support for ScreenOS arp tables (librenms#8273)
Has a buggy implementation of ipNetToMediaPhysAddress
@lock

This comment has been minimized.

Copy link

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.