Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better detection for HiveOS devices #8277

Merged
merged 2 commits into from Mar 23, 2018

Conversation

laf
Copy link
Member

@laf laf commented Feb 21, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This will need a notification but first let's agree that this is what we should do.

aerohive is the vendor rather than an OS. HiveOS is the OS but is shared over switches and aps so I've split the detection out.

Fixes: #7842

@laf laf added Device 🖥️ New or added device support Blocker 🚫 labels Feb 21, 2018
@scrutinizer-notifier
Copy link

The inspection completed: No new issues

Copy link
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send notification and merge when ready.

@laf
Copy link
Member Author

laf commented Mar 19, 2018

Notification sent for the 23rd of March. Do not merge until then.

@murrant murrant merged commit e0589e0 into librenms:master Mar 23, 2018
@laf laf deleted the device/issue-7842 branch March 23, 2018 18:54
TheMysteriousX pushed a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018
* device: Added better detection for HiveOS devices

* Added MIBs for later use
@lock lock bot locked as resolved and limited conversation to collaborators May 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants