New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better detection for HiveOS devices #8277

Merged
merged 2 commits into from Mar 23, 2018

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Feb 21, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This will need a notification but first let's agree that this is what we should do.

aerohive is the vendor rather than an OS. HiveOS is the OS but is shared over switches and aps so I've split the detection out.

Fixes: #7842

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 21, 2018

The inspection completed: No new issues

@murrant

Send notification and merge when ready.

@laf

This comment has been minimized.

Member

laf commented Mar 19, 2018

Notification sent for the 23rd of March. Do not merge until then.

@murrant murrant removed the Blocker 🚫 label Mar 23, 2018

@murrant murrant merged commit e0589e0 into librenms:master Mar 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:device/issue-7842 branch Mar 23, 2018

TheMysteriousX added a commit to TheMysteriousX/librenms that referenced this pull request May 20, 2018

Added better detection for HiveOS devices (librenms#8277)
* device: Added better detection for HiveOS devices

* Added MIBs for later use

@lock lock bot locked as resolved and limited conversation to collaborators May 22, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.