New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: Removed unused JS causing issues with typeahead #8307

Merged
merged 2 commits into from Mar 9, 2018

Conversation

Projects
None yet
2 participants
@laf
Member

laf commented Feb 27, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #8289

Upgraded typeahead to the forked version which is maintained and removed some JS that was added to force height of the cells. Seems like it's not needed and we'll have to deal with any issues that might arise

@laf laf added the WebUI label Feb 27, 2018

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Feb 27, 2018

The inspection completed: No new issues

@laf laf merged commit 9897b5f into librenms:master Mar 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

webui: Removed unused JS causing issues with typeahead (librenms#8307)
* webui: Removed unused JS causing issues with typeahead

* updated reference url for typeahead
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.