New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added auto width and height dimensions parameters #8314

Merged
merged 1 commit into from Mar 1, 2018

Conversation

Projects
None yet
5 participants
@BlackDex
Contributor

BlackDex commented Mar 1, 2018

Added the ability to substituted special parameters for width and height of the Generic-image widget to be added to an Image URL.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Added auto width and height dimensions parameters
Added the ability to substituted special parameters for width and height of the Generic-image widget to be added to an Image URL.
@f0o

f0o approved these changes Mar 1, 2018

LGTM

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Mar 1, 2018

The inspection completed: No new issues

@laf laf merged commit 5af51fa into librenms:master Mar 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@BlackDex BlackDex deleted the BlackDex:generic-image-widget-1 branch Mar 13, 2018

inetAnt added a commit to criteo-forks/librenms that referenced this pull request Mar 19, 2018

webui: Added auto width and height dimensions parameters to generic i…
…mage dashboard widget (librenms#8314)

Added the ability to substituted special parameters for width and height of the Generic-image widget to be added to an Image URL.
@lock

This comment has been minimized.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.