Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixing HP Proliant state sensors #8315
The support to HP Proliant disk discovery was originally introduced at #6124.
However that code contains a few errors that prevent it from doing what it was intended to do.
Having made the changes described herein, the following is seen in the recent events
The only other issue that I can name is that the states are not expanded properly in the UI, i.e. 2 should equal to OK.
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
thanks for that - I've added the change suggested by you and now the states are represented by nice bootstrap style buttons :)
I've also took this opportunity to extend this code and implement the following:
Please let me know if you need anything else.
Well I'd say graphs are still useful. They show the historic state of the sensors over time which can be useful
I think it might be better to leave them in.
With this amount of changes, can you submit test data as well so we can ensure this code works going forward. https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow
Wrong number of spaces, should be good now
OK, thanks for confirming - this is now reverted to original value of 1.
OK, I'll try to do something smart here, since both of these (disk status and SMART status) come from the same snmp table.
OK, will allocate time to this next week.
Unless you update to the state code to the new format, you can't change existing state translations.
@murrant, ok thanks - so I am guessing (haven't tested yet) that, this basically fixes the original problem whereby disk checks were non functioning, but at the same time removes the FAN, PSU and Raid CTRL checks that I added as part of this PR.
How do you want me to progress with adding these changes?
added a commit
this pull request
Mar 19, 2018
@murrant, ok fair enough.
one problem with this code thought - the $drive_bay isn't properly expanded so I am seeing them as follows on a system with 4 disks
While I was expecting Drive 1,2,3,4,what not instead.